From 9c7b28c7b7cfc1c5f411d72e401a947eaba6b06b Mon Sep 17 00:00:00 2001
From: zhangc <zc@123>
Date: 星期二, 14 一月 2025 14:49:16 +0800
Subject: [PATCH] 优化代码，移除冗余，修复bug
---
src/main/java/com/zy/asrs/controller/AgvBasDevpController.java | 99 +++++++++++++++++++++++++++----------------------
1 files changed, 54 insertions(+), 45 deletions(-)
diff --git a/src/main/java/com/zy/asrs/controller/AgvBasDevpController.java b/src/main/java/com/zy/asrs/controller/AgvBasDevpController.java
index feba49f..198d92f 100644
--- a/src/main/java/com/zy/asrs/controller/AgvBasDevpController.java
+++ b/src/main/java/com/zy/asrs/controller/AgvBasDevpController.java
@@ -40,15 +40,17 @@
@RequestMapping(value = "/basDevp/list/auth")
@ManagerAuth
- public R list(@RequestParam(defaultValue = "1")Integer curr,
- @RequestParam(defaultValue = "10")Integer limit,
- @RequestParam(required = false)String orderByField,
- @RequestParam(required = false)String orderByType,
- @RequestParam Map<String, Object> param){
+ public R list(@RequestParam(defaultValue = "1") Integer curr,
+ @RequestParam(defaultValue = "10") Integer limit,
+ @RequestParam(required = false) String orderByField,
+ @RequestParam(required = false) String orderByType,
+ @RequestParam Map<String, Object> param) {
excludeTrash(param);
EntityWrapper<AgvBasDevp> wrapper = new EntityWrapper<>();
convert(param, wrapper);
- if (!Cools.isEmpty(orderByField)){wrapper.orderBy(humpToLine(orderByField), "asc".equals(orderByType));}
+ if (!Cools.isEmpty(orderByField)) {
+ wrapper.orderBy(humpToLine(orderByField), "asc".equals(orderByType));
+ }
return R.ok(agvBasDevpService.selectPage(new Page<>(curr, limit), wrapper));
}
@@ -68,7 +70,7 @@
@ManagerAuth
public R query(@RequestBody JSONObject param) {
Wrapper<AgvBasDevp> wrapper = new EntityWrapper<AgvBasDevp>().eq(humpToLine(String.valueOf(param.get("key"))), param.get("val"));
- if (null != agvBasDevpService.selectOne(wrapper)){
+ if (null != agvBasDevpService.selectOne(wrapper)) {
return R.parse(BaseRes.REPEAT).add(getComment(BasDevp.class, String.valueOf(param.get("key"))));
}
return R.ok();
@@ -82,8 +84,8 @@
@RequestMapping(value = "/basDevp/update/auth")
@ManagerAuth(memo = "绔欑偣淇敼")
- public R update(AgvBasDevp basDevp){
- if (Cools.isEmpty(basDevp) || null==basDevp.getDevNo()){
+ public R update(AgvBasDevp basDevp) {
+ if (Cools.isEmpty(basDevp) || null == basDevp.getDevNo()) {
return R.error("鍙傛暟缂哄け");
}
basDevp.setModiUser(getUserId());
@@ -94,12 +96,12 @@
@RequestMapping(value = "/basDevp/delete/auth")
@ManagerAuth(memo = "绔欑偣鍒犻櫎")
- public R delete(@RequestParam String param){
+ public R delete(@RequestParam String param) {
List<AgvBasDevp> list = JSONArray.parseArray(param, AgvBasDevp.class);
- if (Cools.isEmpty(list)){
+ if (Cools.isEmpty(list)) {
return R.error("鍙傛暟缂哄け");
}
- for (AgvBasDevp entity : list){
+ for (AgvBasDevp entity : list) {
agvBasDevpService.delete(new EntityWrapper<>(entity));
}
return R.ok();
@@ -107,26 +109,26 @@
@RequestMapping(value = "/basDevp/unbind/auth")
@ManagerAuth(memo = "绔欑偣瑙ｇ粦")
- public R unbind(@RequestParam String param){
- AgvBasDevp agvBasDevp = JSONArray.parseObject(param,AgvBasDevp.class);
- if (agvBasDevp==null){
+ public R unbind(@RequestParam String param) {
+ AgvBasDevp agvBasDevp = JSONArray.parseObject(param, AgvBasDevp.class);
+ if (agvBasDevp == null) {
return R.error("鍙傛暟缂哄け");
}
//鑻ュ綋鍓嶇珯鐐硅揣浣嶇姸鎬佷笉涓篎.鍦ㄥ簱鐘舵�侊紝鍒欒繑鍥為敊璇�
- if(!agvBasDevp.getLocSts().equals("F")){
+ if (!agvBasDevp.getLocSts().equals("F")) {
return R.error("褰撳墠绔欑偣璐т綅鐘舵�佷笉涓哄湪搴擄紝鏃犳硶瑙ｉ櫎缁戝畾");
}
agvBasDevp.setLocSts("O");
agvBasDevp.setBarcode("");
agvBasDevp.setLocType2(null);
- agvBasDevpService.update(agvBasDevp,new EntityWrapper<AgvBasDevp>().eq("dev_no",agvBasDevp.getDevNo()));
+ agvBasDevpService.update(agvBasDevp, new EntityWrapper<AgvBasDevp>().eq("dev_no", agvBasDevp.getDevNo()));
return R.ok();
}
@RequestMapping(value = "/basDevp/export/auth")
@ManagerAuth(memo = "绔欑偣瀵煎嚭")
- public R export(@RequestBody JSONObject param){
+ public R export(@RequestBody JSONObject param) {
List<String> fields = JSONObject.parseArray(param.getJSONArray("fields").toJSONString(), String.class);
EntityWrapper<AgvBasDevp> wrapper = new EntityWrapper<>();
Map<String, Object> map = excludeTrash(param.getJSONObject("basDevp"));
@@ -142,7 +144,7 @@
wrapper.like("dev_no", condition);
Page<AgvBasDevp> page = agvBasDevpService.selectPage(new Page<>(0, 10), wrapper);
List<Map<String, Object>> result = new ArrayList<>();
- for (AgvBasDevp basDevp : page.getRecords()){
+ for (AgvBasDevp basDevp : page.getRecords()) {
Map<String, Object> map = new HashMap<>();
map.put("id", basDevp.getDevNo());
map.put("value", basDevp.getDevNo());
@@ -166,25 +168,25 @@
绔欑偣鏄庣粏
*/
@RequestMapping(value = "/basDevp/detail/list/auth")
- public R basDevpDetailList(@RequestParam(defaultValue = "1")Integer curr,
- @RequestParam(defaultValue = "10")Integer limit,
- @RequestParam Map<String, Object> param){
+ public R basDevpDetailList(@RequestParam(defaultValue = "1") Integer curr,
+ @RequestParam(defaultValue = "10") Integer limit,
+ @RequestParam Map<String, Object> param) {
String devNo = param.get("devNo").toString();
- if (Cools.isEmpty(devNo) || !CodeDetectionUtil.carCodeDetection(devNo)){
+ if (Cools.isEmpty(devNo) || !CodeDetectionUtil.carCodeDetection(devNo)) {
throw new CoolException(devNo + "灏忚溅鍦扮爜鏈夎锛岃姝ｇ‘鎵爜锛侊紒锛�");
}
AgvBasDevp agvBasDevp = agvBasDevpService.selectById(devNo);
- if("F".equals(agvBasDevp.getLocSts()) || "R".equals(agvBasDevp.getLocSts())){
+ if ("F".equals(agvBasDevp.getLocSts()) || "R".equals(agvBasDevp.getLocSts())) {
//鍏堝幓鍏ュ簱閫氱煡妗ｆ壘鏄庣粏
Page<AgvWaitPakin> agvWaitPakinPage = agvWaitPakinService.selectPage(new Page<>(curr, limit), new EntityWrapper<AgvWaitPakin>()
.eq("supp_code", agvBasDevp.getBarcode()));
- if(agvWaitPakinPage.getRecords().size()>0){
+ if (agvWaitPakinPage.getRecords().size() > 0) {
return R.ok(agvWaitPakinPage);
- }else {
+ } else {
//濡傛灉鍏ュ簱閫氭。鏄庣粏涓虹┖锛屽垯鍘诲伐浣滄。鎵炬槑缁�
AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>()
.eq("loc_no", agvBasDevp.getDevNo())
- .or().eq("source_loc_no",agvBasDevp.getDevNo()));
+ .or().eq("source_loc_no", agvBasDevp.getDevNo()));
if (Cools.isEmpty(agvWrkMast)) {
Page<AgvLocDetl> agvLocDetlPage = agvLocDetlService.selectPage(new Page<>(curr, limit), new EntityWrapper<AgvLocDetl>()
.eq("supp_code", agvBasDevp.getBarcode()));
@@ -198,7 +200,7 @@
Page<AgvWrkDetl> agvWrkDetlPage = agvWrkDetlService.selectPage(new Page<>(curr, limit), new EntityWrapper<AgvWrkDetl>()
.eq("wrk_no", agvWrkMast.getWrkNo()));
- if(agvWrkDetlPage.getRecords().size()>0){
+ if (agvWrkDetlPage.getRecords().size() > 0) {
return R.ok(agvWrkDetlPage);
}
}
@@ -208,7 +210,7 @@
}
@RequestMapping(value = "/basDevp/visualized/list/auth")
- public R visualizedList(@RequestBody JSONObject param){
+ public R visualizedList(@RequestBody JSONObject param) {
String stationCode = param.get("stationCode").toString();
@@ -216,26 +218,28 @@
return R.ok(result);
}
+
@RequestMapping(value = "/basDevp/visualized/list/auth/v2")
- public R visualizedList(@RequestParam String stationCode){
+ public R visualizedList(@RequestParam String stationCode) {
Map<String, Object> result = agvBasDevpService.getAgvBasDevpDtoByStationCode(stationCode);
return R.ok(result);
}
+
/*
浠诲姟瀹屾垚
*/
@RequestMapping(value = "/basDevp/visualized/container/moveOut")
@ManagerAuth(memo = "纭鍑哄簱")
- public R visualiZedContainerMoveOut(@RequestBody Map<String,Object> map) {
+ public R visualiZedContainerMoveOut(@RequestBody Map<String, Object> map) {
String barcode = map.get("barcode").toString();
- AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts",205L));
- if (agvWrkMast == null){
+ AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts", 205L));
+ if (agvWrkMast == null) {
R.error("宸ヤ綔妗ｄ笉瀛樺湪");
}
- if(agvWrkMast.getIoType() != 101 && agvWrkMast.getIoType() != 110){
+ if (agvWrkMast.getIoType() != 101 && agvWrkMast.getIoType() != 110) {
throw new CoolException("宸ヤ綔鍙蜂负" + agvWrkMast.getWrkNo() + "绫诲瀷涓嶄负101.鍑哄簱锛屾棤娉曟墽琛岃揣鏋剁鍦轰换鍔★紝璇烽噸鏂伴�夋嫨绔欑偣銆�");
}
@@ -251,14 +255,14 @@
*/
@RequestMapping(value = "/basDevp/visualized/container/moveOut2")
@ManagerAuth(memo = "纭鍑哄簱2")
- public R visualiZedContainerMoveOut2(@RequestBody Map<String,Object> map) {
+ public R visualiZedContainerMoveOut2(@RequestBody Map<String, Object> map) {
String barcode = map.get("barcode").toString();
- AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts",205L));
- if (agvWrkMast == null){
+ AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts", 205L));
+ if (agvWrkMast == null) {
return R.error("宸ヤ綔妗ｄ笉瀛樺湪");
}
- if(agvWrkMast.getIoType() != 101 && agvWrkMast.getIoType() != 110){
+ if (agvWrkMast.getIoType() != 101 && agvWrkMast.getIoType() != 110) {
throw new CoolException("宸ヤ綔鍙蜂负" + agvWrkMast.getWrkNo() + "绫诲瀷涓嶄负101.鍑哄簱锛屾棤娉曟墽琛岃揣鏋剁鍦轰换鍔★紝璇烽噸鏂伴�夋嫨绔欑偣銆�");
}
@@ -274,13 +278,19 @@
*/
@RequestMapping(value = "/basDevp/visualized/container/pickIn")
@ManagerAuth(memo = "宸叉嫞鏂欏洖搴�")
- public R visualiZedPickIn(@RequestBody Map<String,Object> map){
+ public R visualiZedPickIn(@RequestBody Map<String, Object> map) {
+ if (Cools.isEmpty(map.get("devNo"))) {
+ return R.error("绔欑偣涓嶈兘涓虹┖");
+ }
+ if (Cools.isEmpty(map.get("barcode"))) {
+ return R.error("璐ф灦鐮佷笉鑳戒负绌�");
+ }
List<AgvWrkMast> agvWrkMastList = new ArrayList<>();
String devNo = map.get("devNo").toString();
String barcode = map.get("barcode").toString();
- AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts",205L));
+ AgvWrkMast agvWrkMast = agvWrkMastService.selectOne(new EntityWrapper<AgvWrkMast>().eq("barcode", barcode).eq("wrk_sts", 205L));
if (agvWrkMast != null) {
- if(agvWrkMast.getIoType() == 101){
+ if (agvWrkMast.getIoType() == 101) {
throw new CoolException("宸ヤ綔鍙蜂负" + agvWrkMast.getWrkNo() + "绫诲瀷涓�101.鍑哄簱锛屾棤娉曟墽琛屾嫞鏂欏叆搴撲换鍔★紝璇烽噸鏂伴�夋嫨绔欑偣銆�");
}
agvWrkMast.setLocNo(devNo);
@@ -291,14 +301,13 @@
}
-
return R.ok("鐢熸垚鎷ｆ枡鍥炲簱浠诲姟鎴愬姛");
}
- private <T> void convert(Map<String, Object> map, EntityWrapper<T> wrapper){
- for (Map.Entry<String, Object> entry : map.entrySet()){
+ private <T> void convert(Map<String, Object> map, EntityWrapper<T> wrapper) {
+ for (Map.Entry<String, Object> entry : map.entrySet()) {
String val = String.valueOf(entry.getValue());
- if (val.contains(RANGE_TIME_LINK)){
+ if (val.contains(RANGE_TIME_LINK)) {
String[] dates = val.split(RANGE_TIME_LINK);
wrapper.ge(entry.getKey(), DateUtils.convert(dates[0]));
wrapper.le(entry.getKey(), DateUtils.convert(dates[1]));
--
Gitblit v1.9.1