From 7d27cdccf8b92f32e80499f1f06c4b8ab93936c1 Mon Sep 17 00:00:00 2001
From: skyouc
Date: 星期一, 26 五月 2025 19:25:34 +0800
Subject: [PATCH] 修改空板移库,任务完成后无法加入历史档问题

---
 rsf-server/src/main/java/com/vincent/rsf/server/manager/schedules/TaskSchedules.java |   36 ++++++++++++++----------------------
 1 files changed, 14 insertions(+), 22 deletions(-)

diff --git a/rsf-server/src/main/java/com/vincent/rsf/server/manager/schedules/TaskSchedules.java b/rsf-server/src/main/java/com/vincent/rsf/server/manager/schedules/TaskSchedules.java
index 4445a74..4349860 100644
--- a/rsf-server/src/main/java/com/vincent/rsf/server/manager/schedules/TaskSchedules.java
+++ b/rsf-server/src/main/java/com/vincent/rsf/server/manager/schedules/TaskSchedules.java
@@ -107,14 +107,6 @@
             return;
         }
 
-        List<Long> list = tasks.stream().map(Task::getId).collect(Collectors.toList());
-        List<TaskItem> taskItems = taskItemService.list(new LambdaQueryWrapper<TaskItem>().in(TaskItem::getTaskId, list));
-        if (taskItems.isEmpty()) {
-            return;
-        }
-
-        Map<Long, List<TaskItem>> listMap = taskItems.stream().collect(Collectors.groupingBy(TaskItem::getTaskId));
-
         tasks.forEach(task -> {
             TaskLog taskLog = new TaskLog();
             BeanUtils.copyProperties(task, taskLog);
@@ -123,9 +115,9 @@
             if (!taskLogService.save(taskLog)) {
                 throw new CoolException("浠诲姟鍘嗗彶妗d繚瀛樺け璐ワ紒锛�");
             }
-
+            List<TaskItem> taskItems = taskItemService.list(new LambdaQueryWrapper<TaskItem>().eq(TaskItem::getTaskId, task.getId()));
             List<TaskItemLog> itemLogs = new ArrayList<>();
-            for (TaskItem item : listMap.get(task.getId())) {
+            for (TaskItem item : taskItems) {
                 TaskItemLog itemLog = new TaskItemLog();
                 BeanUtils.copyProperties(item, itemLog);
                 itemLog.setId(null)
@@ -135,19 +127,19 @@
                 itemLogs.add(itemLog);
             }
 
-            if (!taskItemLogService.saveBatch(itemLogs)) {
-                throw new CoolException("浠诲姟鏄庣粏鍘嗗彶妗d繚瀛樺け璐ワ紒锛�");
+            if (!taskService.removeById(task.getId())) {
+                throw new CoolException("鍘熷浠诲姟鍒犻櫎澶辫触锛侊紒");
+            }
+
+            if (!taskItems.isEmpty()) {
+                if (!taskItemLogService.saveBatch(itemLogs)) {
+                    throw new CoolException("浠诲姟鏄庣粏鍘嗗彶妗d繚瀛樺け璐ワ紒锛�");
+                }
+
+                if (!taskItemService.remove(new LambdaQueryWrapper<TaskItem>().eq(TaskItem::getTaskId, task.getId()))) {
+                    throw new CoolException("鍘熷浠诲姟鏄庣粏鍒犻櫎澶辫触锛侊紒");
+                }
             }
         });
-
-        if (!taskService.removeByIds(list)) {
-            throw new CoolException("鍘熷浠诲姟鍒犻櫎澶辫触锛侊紒");
-        }
-
-        List<Long> itemIds = taskItems.stream().map(TaskItem::getId).collect(Collectors.toList());
-
-        if (!taskItemService.removeByIds(itemIds)) {
-            throw new CoolException("鍘熷浠诲姟鏄庣粏鍒犻櫎澶辫触锛侊紒");
-        }
     }
 }

--
Gitblit v1.9.1